wypoon commented on a change in pull request #4395:
URL: https://github.com/apache/iceberg/pull/4395#discussion_r834765166
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java
##########
@@ -93,6 +93,11 @@
}
}
+ @Override
+ public String description() {
+ return "IcebergScan " + super.description();
+ }
Review comment:
Unfortunately the label for the node in the SQL DAG in the Spark UI just
says "BatchScan" (that is the `nodeName` for a `BatchScanExec` node, and we
can't affect it from Iceberg), but the tool tip for the node contains this
`description`.
Also, the detailed Physical Plan shows this `description`. The `toString`
method also uses "IcebergScan" (I followed its lead), but I don't see the
`toString` being used in the Spark UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
