kbendick commented on pull request #4399: URL: https://github.com/apache/iceberg/pull/4399#issuecomment-1079599018
Yes I would move to close this. `key_metadata` is part of the specification, and one of the most important parts of Iceberg is that it has a strong specification. That's the reason that other engines are able to easily add support for Iceberg - and that organizations are able to fork it and add features in a way that will ideally be compatible in the future. As this is part of the spec, there's no way to say that it's not used in some existing forks. As another note: seeing that a function or field is not used anywhere in the Iceberg codebase isn't always an indication that it is entirely unused. While support for some engines is handled within the Iceberg repo, other engines implement support themselves or within their own code base (e.g. Trino, Apache Drill, etc). So we have to be especially cautious removing things that are "unused" these days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
