rdblue commented on a change in pull request #4280:
URL: https://github.com/apache/iceberg/pull/4280#discussion_r835959782
##########
File path: aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java
##########
@@ -162,6 +190,19 @@ private String cleanWarehousePath(String path) {
@Override
protected TableOperations newTableOps(TableIdentifier tableIdentifier) {
+ if (catalogProperties != null) {
+ Map<String, String> tableSpecificCatalogProperties =
ImmutableMap.<String, String>builder()
+ .putAll(catalogProperties)
+ .put(AwsProperties.LAKE_FORMATION_DB_NAME,
+ IcebergToGlueConverter.getDatabaseName(tableIdentifier))
+ .put(AwsProperties.LAKE_FORMATION_TABLE_NAME,
+ IcebergToGlueConverter.getTableName(tableIdentifier))
Review comment:
@xiaoxuandev and @jackye1995, I agree with the comment above that this
seems confusing. If catalog properties are non-null, then lake formation logic
is applied. I think at least the addition of these properties should be
conditional on lake formation enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
