kbendick commented on a change in pull request #4396:
URL: https://github.com/apache/iceberg/pull/4396#discussion_r835981185
##########
File path:
spark/v3.2/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/parser/extensions/IcebergSparkSqlExtensionsParser.scala
##########
@@ -177,11 +189,6 @@ class IcebergSparkSqlExtensionsParser(delegate:
ParserInterface) extends ParserI
private def isIcebergCommand(sqlText: String): Boolean = {
val normalized = sqlText.toLowerCase(Locale.ROOT).trim()
Review comment:
Resolving this as we've decided that having the `normalizeSqlText`
function exist outside the scope of `isIcebergCommand` could potentially lead
to issues as the antlr parser should be responsible for actually processing the
sqlText.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
