rajarshisarkar commented on a change in pull request #4377:
URL: https://github.com/apache/iceberg/pull/4377#discussion_r836178351
##########
File path: api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java
##########
@@ -88,6 +88,15 @@
String USE_STARTING_SEQUENCE_NUMBER = "use-starting-sequence-number";
boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = true;
+ /**
+ * Forces the compaction order according to the partition size in decreasing
order, instead of
Review comment:
I see, I have made the changes to introduce `rewrite.job-order =
{"bytes", "files", "none"}`.
* If `rewrite.job-order=bytes`, then compact based on ascending order of
partition size in bytes.
* If `rewrite.job-order=files`, then compact based on descending order of
number of files.
* If `rewrite.job-order=none`, then compact based on partition order.
Do you feel if there is a use case for descending order for partition size
in bytes / ascending order of number of files? Or maybe some custom option
which lets the user to pass any comparator as per their choice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]