rdblue commented on a change in pull request #4393:
URL: https://github.com/apache/iceberg/pull/4393#discussion_r836570972
##########
File path: aliyun/src/main/java/org/apache/iceberg/aliyun/oss/OSSOutputFile.java
##########
@@ -25,15 +25,17 @@
import org.apache.iceberg.io.InputFile;
import org.apache.iceberg.io.OutputFile;
import org.apache.iceberg.io.PositionOutputStream;
+import org.apache.iceberg.metrics.MetricsContext;
class OSSOutputFile extends BaseOSSFile implements OutputFile {
- OSSOutputFile(OSS client, OSSURI uri, AliyunProperties aliyunProperties) {
- super(client, uri, aliyunProperties);
+ OSSOutputFile(OSS client, OSSURI uri, AliyunProperties aliyunProperties,
MetricsContext metrics) {
+ super(client, uri, aliyunProperties, metrics);
}
- static OSSOutputFile fromLocation(OSS client, String location,
AliyunProperties aliyunProperties) {
- return new OSSOutputFile(client, new OSSURI(location), aliyunProperties);
+ static OSSOutputFile fromLocation(OSS client, String location,
AliyunProperties aliyunProperties,
Review comment:
This is only used in tests as far as I can tell. How about not updating
it and passing `nullMetrics` here? That will cut down on unnecessary test
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
