dramaticlly commented on a change in pull request #4436:
URL: https://github.com/apache/iceberg/pull/4436#discussion_r839015504
##########
File path: python/src/iceberg/expression/literals.py
##########
@@ -200,78 +205,52 @@ def _(self, type_var):
return self
-class IntegerLiteral(Literal[int]):
Review comment:
lovely, did not realized we can actually ditch this entirely. But
looking at the rest of the change altogether, it make more sense as LongLiteral
is probably works fine behind the scene and when explicitly convert to
IntegerType, we enforce the java like min and max but we are still return
LongLiteral in the end but provide a better bound
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
