wypoon commented on pull request #4395: URL: https://github.com/apache/iceberg/pull/4395#issuecomment-1084083153
I have updated the PR. I renamed the metric "numSplits" and its description is now "number of file splits read" (this is what appears in the Spark UI). I also changed "IcebergScan" to "IcebergBatchScan" in the `description` and `toString` methods of `SparkBatchQueryScan`. For now, I am not adding any other metrics in this PR. Task metrics do not appear to be the right mechanism for computing how many delete files are applied, for example. I will look into other metrics for which task metrics are the right mechanism, but that can be a separate PR. I am open to computing min, median and max for the numSplits metric if that is desired. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
