rdblue commented on issue #4435: URL: https://github.com/apache/iceberg/issues/4435#issuecomment-1086049599
That seems like a lot of files to me, and some of them only have a few classes. I'd probably move the classes that are expressions into the base or have one file instead of operation.py, predicate.py, and references.py. Visitors I think should probably be their own thing, but I'd put visitors and evaluators together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
