flyrain commented on a change in pull request #4456:
URL: https://github.com/apache/iceberg/pull/4456#discussion_r840899312
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -402,9 +404,27 @@ private void setHmsTableParameters(String
newMetadataLocation, Table tbl, TableM
parameters.put(StatsSetupConst.TOTAL_SIZE,
summary.get(SnapshotSummary.TOTAL_FILE_SIZE_PROP));
}
+ setSnapshotStats(metadata, parameters);
+
tbl.setParameters(parameters);
}
+ private void setSnapshotStats(TableMetadata metadata, Map<String, String>
parameters) {
+ Snapshot currentSnapshot = metadata.currentSnapshot();
+ if (currentSnapshot != null) {
+ parameters.put(TableProperties.CURRENT_SNAPSHOT_ID,
String.valueOf(currentSnapshot.snapshotId()));
+ parameters.put(TableProperties.CURRENT_SNAPSHOT_TIMESTAMP,
String.valueOf(currentSnapshot.timestampMillis()));
+ try {
+ parameters.put(TableProperties.CURRENT_SNAPSHOT_SUMMARY,
+ JsonUtil.mapper().writeValueAsString(currentSnapshot.summary()));
Review comment:
Good question! According to
https://issues.apache.org/jira/browse/HIVE-12274 and
https://issues.apache.org/jira/browse/HIVE-14145, we can at least store 4000
chars as the values before HMS3.x, and more in HMS3.x depending on the under
layer RDMS, at least 32672 bytes. I'm going to cap it at 4000 chars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
