rdblue commented on pull request #4307: URL: https://github.com/apache/iceberg/pull/4307#issuecomment-1086349756
Yeah, if you don't mind it would be great to get rid of those Thread.sleep calls! And it would still be a good idea to add `waitUntilAfter` here. Since this is using `System.currentTimeMillis` in the next line, I suspect that the tests may be flaky without waiting until after the current millisecond before the expiration call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
