rdblue commented on a change in pull request #4438:
URL: https://github.com/apache/iceberg/pull/4438#discussion_r841246873
##########
File path: hive3/src/main/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java
##########
@@ -191,12 +191,12 @@ public boolean hasFooter() {
}
/**
- * @return {@code true} if file schema doesn't have Acid metadata columns
* Such file may be in a delta_x_y/ or base_x due to being added via
* "load data" command. It could be at partition|table root due to table
having
* been converted from non-acid to acid table. It could even be something
like
* "warehouse/t/HIVE_UNION_SUBDIR_15/000000_0" if it was written by an
* "insert into t select ... from A union all select ... from B"
+ * @return {@code true} if file schema doesn't have Acid metadata columns
Review comment:
I think the right fix is to document the method, not to just move the
`@return`. Can you fix the documentation here instead? Javadoc should start
with a short (one sentence) description and then go into more detail if needed
after a paragraph break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
