szehon-ho commented on code in PR #4456: URL: https://github.com/apache/iceberg/pull/4456#discussion_r844197174
########## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ########## @@ -90,6 +92,7 @@ private static final String HIVE_LOCK_CHECK_MAX_WAIT_MS = "iceberg.hive.lock-check-max-wait-ms"; private static final String HIVE_ICEBERG_METADATA_REFRESH_MAX_RETRIES = "iceberg.hive.metadata-refresh-max-retries"; private static final String HIVE_TABLE_LEVEL_LOCK_EVICT_MS = "iceberg.hive.table-level-lock-evict-ms"; + private static final long HIVE_TABLE_PROPERTY_VALUE_SIZE_MAX = 4000; Review Comment: I guess my comment is not complete, @flyrain's analysis in https://github.com/apache/iceberg/pull/4456#discussion_r840899312 is the exact one. Older versions of Hive had the 4000 limit (due to need to support some older databases), and newer versions increased to 32672. So, if we don't have some kind of flag, we lose the full potential of current HMS versions just to support the older ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
