szehon-ho commented on code in PR #4516:
URL: https://github.com/apache/iceberg/pull/4516#discussion_r845397874
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -164,17 +165,20 @@ Partition get(StructLike key) {
}
static class Partition {
+ private int specId;
private final StructLike key;
private long recordCount;
private int fileCount;
Partition(StructLike key) {
+ this.specId = 0;
Review Comment:
I'm wondering one thing , didn't test it myself.
If we have two partitions with different spec id but different key, it will
show up with a random one. Could this case happen (ie, adding and removing a
field in partition spec should give a new spec id but can still produce the
same partition value?)? If so, we may need to add spec-id to key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
