aokolnychyi commented on code in PR #4520:
URL: https://github.com/apache/iceberg/pull/4520#discussion_r845644285
##########
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##########
@@ -113,17 +116,19 @@ public TableScan appendsAfter(long fromSnapshotId) {
*/
protected abstract CloseableIterable<ManifestFile> manifests();
- private CloseableIterable<ManifestFile>
filterManifests(CloseableIterable<ManifestFile> manifests,
- Expression
rowFilter,
- boolean
caseSensitive) {
+
+ private boolean filter(ManifestFile manifestFile, Expression rowFilter,
boolean caseSensitive) {
Review Comment:
It looks like a bug in `transformSpec` that assumes old partition fields are
never renamed. If we switch to using column IDs, will it help?
```
static PartitionSpec transformSpec(Schema metadataTableSchema, PartitionSpec
spec) {
PartitionSpec.Builder identitySpecBuilder =
PartitionSpec.builderFor(metadataTableSchema).checkConflicts(false);
spec.fields().forEach(pf -> identitySpecBuilder.add(pf.fieldId(),
pf.name(), "identity"));
return identitySpecBuilder.build();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
