liuml07 opened a new pull request, #4558: URL: https://github.com/apache/iceberg/pull/4558
I learnt from a PR review that `Precondition.checkArgument` only support `%s` in the error message template. See [Guava doc](https://github.com/google/guava/wiki/PreconditionsExplained). I see there are a few places in our code that uses `%d`. This simple PR is to replace `%d` with `%s` so that error message will be formatted exactly as intended. The patch was generated using following command: ```bash # one line find . -name "*.java" | xargs sed -i '' '/Preconditions.checkArgument/ s/%d/%s/g' # two lines find . -name "*.java" | xargs sed -i '' '/Preconditions.checkArgument.*,$/{n;s/%d/%s/g;}' ``` I "reviewed" the patch and it seems good. I do not see other format pattern like `%f` or `%t` in existing code. Let me know if this auto-generated code makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
