kbendick commented on PR #4519: URL: https://github.com/apache/iceberg/pull/4519#issuecomment-1100221967
> > Is there any blocker that we cannot just fix this bug in flink 1.12 ? In my context, I think the approach to fix the bug in fink 1.12 is just porting the patch from flink1.13/1.14 to flink1.12, I usually just export it to a patch file and replace the v1.14 to v1.12 globally. > > My understanding is that there is a bug in Flink 1.12 that prevents us from fixing this, but I'm not sure what that is. I think we'll need @kbendick to jump in and give the details. > > I agree with you, if we can easily adapt the fix for 1.13 and 1.14, then we should just fix it! @rdblue is correct. The patch from https://github.com/apache/iceberg/pull/4364 didn't work with Flink 1.12. The problem still persists. https://github.com/apache/iceberg/pull/4418 did not pass all unit tests and I was not able to resolve them. So I agree with Ryan that it's probably better to disable this one feature instead of continue to allow users to get incorrect results. If they're somehow ok with the results they're getting, they can remain on Iceberg 0.13.1. I repushed the branch from https://github.com/apache/iceberg/pull/4418 that originally had the patch for 1.12 . Let me try using `DATE` instead of `TO_DATE` to see if that resolves the issue. Otherwise, I think it's best to continue to disable this one feature in 1.12, given that we'll be removing 1.12 in the next major release anyway. But if we can't get it to work, I don't think we should block the patch release on fixing it given that technically Flink 1.12 is deprecated upstream anyway and we've removed support in Iceberg 0.14.0-SNAPSHOT too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
