samredai commented on code in PR #4675: URL: https://github.com/apache/iceberg/pull/4675#discussion_r865458271
########## docs/api/java-api-quickstart.md: ########## @@ -66,6 +66,17 @@ Table table = catalog.createTable(name, schema, spec); The logs [schema](#create-a-schema) and [partition spec](#create-a-partition-spec) are created below. +HiveCatalog supports registering the table using an existing metadata JSON file as below: Review Comment: That's a good point. in my opinion the docs in general are due for some sections that purely focus on catalogs (see figure 2 in this docs site [proposal](https://docs.google.com/document/d/1Y_PRv6p5oJaxg_68AUia_JHw8P4-AZIu3hP5IH2Cpsw/edit) presented at the sync this morning). There's quite a bit there which is why a quick-start probably won't provide enough open space to cover any catalog implementation in detail. At the most, I'd say a quick-start should load an InMemory catalog (once that implementation is ready) and link off to comprehensive catalog docs that cover production grade catalogs. What do you think of shifting this to a new `hive_catalog.md` file that we can add into the new catalog section when it's ready? I can help structure that page and fill it with other content that I think is missing right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
