kbendick commented on code in PR #4746:
URL: https://github.com/apache/iceberg/pull/4746#discussion_r870634655


##########
docs/spark/spark-ddl.md:
##########
@@ -134,6 +134,11 @@ To delete a table, run:
 DROP TABLE prod.db.sample
 ```
 
+To delete an empty table use `PURGE`, run:
+
+```sql
+DROP TABLE prod.db.sample PURGE
+```

Review Comment:
   Nit: I understand what you mean, but i think the saying "to delete an empty 
table" might be somewhat confusing for relatively new users.
   
   How about something like the following?
   
   ```
   To  delete a table as well as its underlying data, use the `PURGE` flag. 
   
   The `PURGE` flag can also be used to remove an empty table from its 
corresponding catalog if the table's metadata files have been removed by some 
other process.
   ```
   
   Not sure the best wording for the second statement .  The second statement 
might fit better somewhere else if we're only addressing the edge case of a 
table's metadata files being deleted by some other process.
   
   But please correct me if we're concerned with more than that edge case for 
"an empty table".
   
   Tagging @samredai for his thoughts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to