[GitHub] [iceberg] Fokko opened a new pull request, #4814: Python: Fix the type_string of the NestedField

[GitBox]

Fokko opened a new pull request, #4814:
URL: https://github.com/apache/iceberg/pull/4814

   If there is a doc, the rest gets ignored, which is kind of awkward.
   
   Before:
   ```python
   ➜  python git:(master) ✗ python3
   Python 3.9.12 (main, Mar 26 2022, 15:44:31)
   [Clang 13.1.6 (clang-1316.0.21.2)] on darwin
   Type "help", "copyright", "credits" or "license" for more information.
   >>> from iceberg.types import NestedField, LongType
   >>> str(NestedField(
   ...     field_id=2,
   ...     name='bar',
   ...     field_type=LongType(),
   ...     is_optional=False,
   ...     doc="Just a long"
   ... ))
   '2: bar: required long'
   >>> str(NestedField(
   ...     field_id=2,
   ...     name='bar',
   ...     field_type=LongType(),
   ...     is_optional=False,
   ...     doc="Just a long"
   ... ))
   ' (Just a long)'
   ```
   
   Now:
   ```python
   ➜  python git:(master) ✗ python3
   Python 3.9.12 (main, Mar 26 2022, 15:44:31)
   [Clang 13.1.6 (clang-1316.0.21.2)] on darwin
   Type "help", "copyright", "credits" or "license" for more information.
   >>> str(NestedField(
   ...     field_id=2,
   ...     name='bar',
   ...     field_type=LongType(),
   ...     is_optional=False,
   ...     doc="Just a long"
   ... ))
   '2: bar: required long (Just a long)'
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org