amogh-jahagirdar commented on PR #4578: URL: https://github.com/apache/iceberg/pull/4578#issuecomment-1141645706
Ok, I think I see what's going on. The failing incremental scan test can't find a staged snapshot because the updated expiration logic actually will remove it. Expire snapshots previously would retain staged snapshots so long as it's not outside of the "expire older than" age. However, in this updated logic, we're not considering that for *unreferenced* staged snapshots. Age retention is only applied to snapshots which are part of branches. I think we definitely want to preserve the existing behavior to avoid deleting snapshots that people may expect should be retained, so I will add logic for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
