kbendick commented on code in PR #4919: URL: https://github.com/apache/iceberg/pull/4919#discussion_r886067747
########## dev/source-release.sh: ########## @@ -112,7 +112,7 @@ tarball=$tag.tar.gz git archive $release_hash --worktree-attributes --prefix $tag/ -o $projectdir/$tarball echo "Signing the tarball..." -[[ -z "$keyid" ]] && keyopt="-u $keyid" +[[ -n "$keyid" ]] && keyopt="-u $keyid" Review Comment: Nit / follow up - eventually we might want to move away from these admittedly “idiomatic” bash one-liners to something that’s a bit more readable but that’s a style preference for another day. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
