dramaticlly commented on code in PR #4811: URL: https://github.com/apache/iceberg/pull/4811#discussion_r886153904
########## python/Makefile: ########## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: I think this Makefile make our life easier, but I guess some of them can even go into pyproject.toml if used with [`taskipy`](https://github.com/illBeRoy/taskipy) for arbitrary task execution? ```toml [tool.taskipy.tasks] lint = """ task lint_isort && task lint_black """ lint_isort = "isort src tests" lint_black = "black src tests" coverage = """ coverage run --source=src/ -m pytest tests/ && coverage report -m --fail-under=90 && coverage html && coverage xml """ ``` It can also be used with poetry directly like `poetry run task coverage` or simply `task coverage` if one don't use poetry -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
