aokolnychyi commented on code in PR #4886:
URL: https://github.com/apache/iceberg/pull/4886#discussion_r886200482
##########
core/src/main/java/org/apache/iceberg/TableScanContext.java:
##########
@@ -169,7 +169,7 @@ Long fromSnapshotId() {
return fromSnapshotId;
}
- TableScanContext fromSnapshotId(long id) {
+ TableScanContext fromSnapshotIdExclusive(long id) {
return new TableScanContext(snapshotId, rowFilter, ignoreResiduals,
caseSensitive, colStats, projectedSchema, selectedColumns, options,
id, toSnapshotId,
planExecutor, fromSnapshotInclusive);
Review Comment:
nit: I think we should probably pass `false` explicitly instead of using
`fromSnapshotInclusive`.
##########
core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java:
##########
@@ -132,7 +132,7 @@ public static Snapshot oldestAncestor(Table table) {
* @param lookup lookup function from snapshot ID to snapshot
* @return null if there is no current snapshot in the table, else the
oldest Snapshot.
*/
- public static Snapshot oldestAncestor(long snapshotId, Function<Long,
Snapshot> lookup) {
+ public static Snapshot oldestAncestorOf(long snapshotId, Function<Long,
Snapshot> lookup) {
Review Comment:
It was just added and hasn't been released. All other methods in this class
follow this name pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
