amogh-jahagirdar commented on code in PR #4922:
URL: https://github.com/apache/iceberg/pull/4922#discussion_r887275892
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -752,7 +753,19 @@ private static Map<String, SnapshotRef> validateRefs(Long
currentSnapshotId,
}
public static Builder buildFrom(TableMetadata base) {
Review Comment:
We do it here because any operation interacting with the builder would use
buildFrom and then the main ref can be set if it doesn't exist in base. I'll
add a test if this is the direction we want to go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
