rdblue commented on code in PR #4956:
URL: https://github.com/apache/iceberg/pull/4956#discussion_r890358534
##########
spark/v3.0/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
##########
@@ -174,6 +175,10 @@ private void commitOperation(SnapshotUpdate<?> operation,
String description) {
extraSnapshotMetadata.forEach(operation::set);
}
+ if (!CallerWithCommitMetadata.commitProperties().isEmpty()) {
+ CallerWithCommitMetadata.commitProperties().forEach(operation::set);
+ }
Review Comment:
I don't think that we need to worry about this. It is unlikely to conflict
and if it does conflict, it's up to the caller to decide what to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
