rdblue commented on code in PR #4945: URL: https://github.com/apache/iceberg/pull/4945#discussion_r895212851
########## format/spec.md: ########## @@ -496,6 +496,7 @@ A snapshot consists of the following fields: | _optional_ | | **`manifests`** | A list of manifest file locations. Must be omitted if `manifest-list` is present | | _optional_ | _required_ | **`summary`** | A string map that summarizes the snapshot changes, including `operation` (see below) | | _optional_ | _optional_ | **`schema-id`** | ID of the table's current schema when the snapshot was created | +| | _optional_ | **`statistics`** | A list of [statistics files' metadata](#statistics-file). The field should be retained by writers, unless writer updates the statistics, or knows they became obsolete. | Review Comment: I looked at the other PR, but I don't follow the argument here that it would make more sense to pass stats in memory. Whether you base stats on the previous file or not doesn't matter to the commit phase. The process updating stats produces a file and then sets it as the current one on a snapshot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
