aokolnychyi commented on code in PR #5077:
URL: https://github.com/apache/iceberg/pull/5077#discussion_r900471294
##########
api/src/main/java/org/apache/iceberg/Scan.java:
##########
@@ -29,7 +29,7 @@
* Scan objects are immutable and can be shared between threads. Refinement
methods, like
* {@link #select(Collection)} and {@link #filter(Expression)}, create new
TableScan instances.
*/
-public interface Scan<T extends Scan<T>> {
+public interface Scan<ThisT, T extends ScanTask, S extends InputSplit<T>> {
Review Comment:
I am debating whether we need to attach a boundary to `ThisT`. It won't harm
but we don't do that in any other places and it makes the definition a bit more
cumbersome as `Scan` has 3 params now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
