pvary commented on code in PR #5036:
URL: https://github.com/apache/iceberg/pull/5036#discussion_r902446203
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCommitLocks.java:
##########
@@ -72,10 +77,17 @@ public class TestHiveCommitLocks extends HiveTableBaseTest {
LockResponse notAcquiredLockResponse = new LockResponse(dummyLockId,
LockState.NOT_ACQUIRED);
@BeforeClass
- public static void initializeSpies() throws Exception {
+ public static void startMetastore() throws Exception {
+ HiveMetastoreTest.hiveConf = new HiveConf();
+ HiveMetastoreTest.hiveConf.set(HiveConf.ConfVars.HIVE_TXN_TIMEOUT.varname,
"1s");
+ HiveMetastoreTest.startMetastore();
Review Comment:
Could we create a:
```
HiveMetastoreTest.startMetastore(Map<String, String> override) {
}
```
in the `HiveMetastoreTest` class? It might be more readable than this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
