RussellSpitzer commented on code in PR #5077:
URL: https://github.com/apache/iceberg/pull/5077#discussion_r902763881
##########
core/src/main/java/org/apache/iceberg/BaseFileScanTask.java:
##########
@@ -217,6 +218,18 @@ public Iterable<FileScanTask> split(long splitSize) {
throw new UnsupportedOperationException("Cannot split a task which is
already split");
}
+ @Override
+ public boolean isAdjacent(FileScanTask other) {
+ return file().equals(other.file()) && offset + len == other.start();
Review Comment:
In the other code we assume there is an ordering of the files.
1 is adjacent to 2
2 is not adjacent to 1
We may want to change the api definition just to note that it is not
commutative
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
