rdblue commented on code in PR #5118:
URL: https://github.com/apache/iceberg/pull/5118#discussion_r905582138
##########
core/src/main/java/org/apache/iceberg/BaseSnapshot.java:
##########
@@ -32,7 +32,8 @@
import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
-class BaseSnapshot implements Snapshot {
+// visible for testing
+public class BaseSnapshot implements Snapshot {
Review Comment:
Do you mean that these are in `org.apache.iceberg` and the test is in
`org.apache.iceberg.rest.responses`? All of the classes are in the core module.
I don't think there is a need for this change. Because we delegate to the
`TableMetadataParser`, we just need to make sure that metadata makes it through
correctly. We don't need to make a complicated `TableMetadata` instance.
Instead, rely on `TableMetadataParser` to be correct. The metadata in should
match the metadata coming out, but we don't want to do a ton of work to simply
exercise `TableMetadataParser`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
