RussellSpitzer commented on code in PR #3435:
URL: https://github.com/apache/iceberg/pull/3435#discussion_r906303299
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetUtil.java:
##########
@@ -70,12 +75,14 @@ public class ParquetUtil {
private ParquetUtil() {
}
- public static Metrics fileMetrics(InputFile file, MetricsConfig
metricsConfig) {
Review Comment:
We are changing two public apis in our utility class here, while we don't
guarantee compatibility here this may be an issue it also is a bit confusing
that this fileMetrics function now also checks Schema since i'm not sure that
really relates?
I think it probably is ok to do that modification since we can basically say
this is a precondition?
So maybe "Precondition.checkArg(canImportSchema...?") In that case we do
need to probably still keep a version without schema but let's deprecate that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
