hililiwei commented on code in PR #4904: URL: https://github.com/apache/iceberg/pull/4904#discussion_r910929465
########## flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/sink/v2/IcebergStreamWriter.java: ########## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.flink.sink.v2; + +import java.io.IOException; +import java.util.Collection; +import java.util.List; +import org.apache.flink.api.connector.sink2.SinkWriter; +import org.apache.flink.api.connector.sink2.StatefulSink.StatefulSinkWriter; +import org.apache.flink.api.connector.sink2.TwoPhaseCommittingSink; +import org.apache.flink.table.data.RowData; +import org.apache.iceberg.flink.sink.TaskWriterFactory; +import org.apache.iceberg.io.TaskWriter; +import org.apache.iceberg.io.WriteResult; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; + +public class IcebergStreamWriter implements + StatefulSinkWriter<RowData, IcebergStreamWriterState>, + SinkWriter<RowData>, + TwoPhaseCommittingSink.PrecommittingSinkWriter<RowData, IcebergFlinkCommittable> { + + private static final long serialVersionUID = 1L; + + private final String fullTableName; + private TaskWriterFactory<RowData> taskWriterFactory; + private transient TaskWriter<RowData> writer; + private transient String jobId; + private transient int subTaskId; + private transient long attemptId; + private List<IcebergFlinkCommittable> writeResultsRestore = Lists.newArrayList(); + + public IcebergStreamWriter(String fullTableName, TaskWriter<RowData> writer, int subTaskId, + long attemptId) { + this.fullTableName = fullTableName; + this.writer = writer; + this.subTaskId = subTaskId; + this.attemptId = attemptId; + } + + public IcebergStreamWriter(String fullTableName, + TaskWriterFactory<RowData> taskWriterFactory, + String jobId, int subTaskId, + long attemptId) { + this.fullTableName = fullTableName; + this.jobId = jobId; + this.subTaskId = subTaskId; + this.attemptId = attemptId; + this.taskWriterFactory = taskWriterFactory; + // Initialize the task writer factory. + taskWriterFactory.initialize(subTaskId, attemptId); + // Initialize the task writer. + this.writer = taskWriterFactory.create(); + } + + public void writeResults(List<IcebergFlinkCommittable> newWriteResults) { + this.writeResultsRestore = newWriteResults; + } + + @Override + public void write(RowData element, Context context) throws IOException, InterruptedException { + writer.write(element); + } + + @Override + public void flush(boolean endOfInput) throws IOException { Review Comment: `prepareCommit` will be called whether checkpoint is enabled or not, so I'm not calling it manually like V1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
