kbendick commented on code in PR #5120: URL: https://github.com/apache/iceberg/pull/5120#discussion_r912563742
########## flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/sink/PartitionTransformUdf.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the Licenet ideajoinet ideajoin for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.flink.sink; + +import org.apache.flink.table.annotation.DataTypeHint; +import org.apache.flink.table.annotation.InputGroup; +import org.apache.flink.table.functions.ScalarFunction; +import org.apache.iceberg.expressions.Literals; +import org.apache.iceberg.transforms.Transform; +import org.apache.iceberg.transforms.Transforms; +import org.apache.iceberg.types.Type; +import org.apache.iceberg.types.TypeUtil; + +public class PartitionTransformUdf { + + public static class Truncate extends ScalarFunction { + public String eval(int num, @DataTypeHint(inputGroup = InputGroup.ANY) Object obj) { Review Comment: It seems like maybe adding the TypeInference might be a good way to go. In addition to adding a specific function for each type. That way, if I'm not mistaken, the compiler will be able to reject any invalid input. Then, as Ryan mentioned, we should have a function for each possible type and the correct function should be picked ahead of time based on type from the compiler. This would avoid the runtime reflection used on each function call which has large overheard and should be avoided whenever possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
