szehon-ho commented on code in PR #4812: URL: https://github.com/apache/iceberg/pull/4812#discussion_r919441960
########## core/src/main/java/org/apache/iceberg/PositionDeletesTable.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg; + +import java.util.Map; +import org.apache.iceberg.io.DeleteSchemaUtil; + +public class PositionDeletesTable extends BaseMetadataTable { + + PositionDeletesTable(TableOperations ops, Table table) { + super(ops, table, table.name() + ".position_deletes"); + } + + PositionDeletesTable(TableOperations ops, Table table, String name) { + super(ops, table, name); + } + + @Override + MetadataTableType metadataTableType() { + return MetadataTableType.POSITION_DELETES; + } + + @Override + public TableScan newScan() { + return new PositionDeletesTableScan(operations(), table(), schema()); + } + + @Override + public Schema schema() { + return DeleteSchemaUtil.metadataTableSchema(table()); + } + + @Override + public PartitionSpec spec() { + return table().spec(); Review Comment: Actually this crashes if it is not there. See this code BaseDataReader::constantsMap, where partition field is populated, it will know to get it from the constants (FileScanTask) else it gets it from -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
