szehon-ho commented on code in PR #4812:
URL: https://github.com/apache/iceberg/pull/4812#discussion_r919547379
##########
core/src/main/java/org/apache/iceberg/DataFiles.java:
##########
@@ -108,6 +108,29 @@ public static DataFile fromManifest(ManifestFile manifest)
{
.build();
}
+ public static DataFile fromPositionDelete(DeleteFile deleteFile,
PartitionSpec spec) {
Review Comment:
In the end, decided to make the method work for both kind of delete files,
as the DeleteFile object should not be different:
https://github.com/apache/iceberg/pull/4812#discussion_r918441075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
