wuwenchi commented on code in PR #5120:
URL: https://github.com/apache/iceberg/pull/5120#discussion_r919596805
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java:
##########
@@ -624,7 +635,12 @@ public List<String> listFunctions(String dbName) throws
CatalogException {
@Override
public CatalogFunction getFunction(ObjectPath functionPath) throws
FunctionNotExistException, CatalogException {
- throw new FunctionNotExistException(getName(), functionPath);
+ CatalogFunction catalogFunction =
partitionFunctions.get(functionPath.getObjectName());
Review Comment:
My original idea was that these functions belong to the catalog (it may not
appropriate now) and that the functions are registered when the catalog is
created so that users can use them directly. So I provide the function in
`getFunctions` and show the function in `listFunctions`. If the function is not
displayed to the user now, and these functions cannot be get directly (also
functions will not be directly registered in the catalog), should we mention
these functions in the documentation, and provide an example for register and
use function ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
