amogh-jahagirdar commented on code in PR #5281:
URL: https://github.com/apache/iceberg/pull/5281#discussion_r926357330
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -73,6 +73,10 @@ statement
| ALTER TABLE multipartIdentifier WRITE writeSpec
#setWriteDistributionAndOrdering
| ALTER TABLE multipartIdentifier SET IDENTIFIER_KW FIELDS fieldList
#setIdentifierFields
| ALTER TABLE multipartIdentifier DROP IDENTIFIER_KW FIELDS fieldList
#dropIdentifierFields
+ | ALTER TABLE multipartIdentifier CREATE TAG identifier (AS OF VERSION
snapshotId)? (RETAIN FOR snapshotRefRetain snapshotRefRetainTimeUnit)?
#createTag
+ | ALTER TABLE multipartIdentifier REPLACE TAG identifier (AS OF VERSION
snapshotId)? (RETAIN FOR snapshotRefRetain snapshotRefRetainTimeUnit)?
#replaceTag
+ | ALTER TABLE multipartIdentifier DROP TAG identifier #removeTag
+ | ALTER TABLE multipartIdentifier ALTER TAG identifier RETAIN
snapshotRefRetain snapshotRefRetainTimeUnit #alterTagRetention
Review Comment:
RETAIN FOR instead of just Retain?
##########
spark/v3.3/spark-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4:
##########
@@ -73,6 +73,10 @@ statement
| ALTER TABLE multipartIdentifier WRITE writeSpec
#setWriteDistributionAndOrdering
| ALTER TABLE multipartIdentifier SET IDENTIFIER_KW FIELDS fieldList
#setIdentifierFields
| ALTER TABLE multipartIdentifier DROP IDENTIFIER_KW FIELDS fieldList
#dropIdentifierFields
+ | ALTER TABLE multipartIdentifier CREATE TAG identifier (AS OF VERSION
snapshotId)? (RETAIN FOR snapshotRefRetain snapshotRefRetainTimeUnit)?
#createTag
+ | ALTER TABLE multipartIdentifier REPLACE TAG identifier (AS OF VERSION
snapshotId)? (RETAIN FOR snapshotRefRetain snapshotRefRetainTimeUnit)?
#replaceTag
+ | ALTER TABLE multipartIdentifier DROP TAG identifier #removeTag
+ | ALTER TABLE multipartIdentifier ALTER TAG identifier RETAIN
snapshotRefRetain snapshotRefRetainTimeUnit #alterTagRetention
Review Comment:
For consistency, RETAIN FOR instead of just Retain?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
