findepi commented on code in PR #4945:
URL: https://github.com/apache/iceberg/pull/4945#discussion_r929010642
##########
core/src/main/java/org/apache/iceberg/puffin/Blob.java:
##########
@@ -30,29 +30,23 @@
public final class Blob {
private final String type;
private final List<Integer> inputFields;
- private final long snapshotId;
- private final long sequenceNumber;
private final ByteBuffer blobData;
private final PuffinCompressionCodec requestedCompression;
private final Map<String, String> properties;
- public Blob(
- String type, List<Integer> inputFields, long snapshotId, long
sequenceNumber,
- ByteBuffer blobData) {
- this(type, inputFields, snapshotId, sequenceNumber, blobData, null,
ImmutableMap.of());
+ public Blob(String type, List<Integer> inputFields, ByteBuffer blobData) {
+ this(type, inputFields, blobData, null, ImmutableMap.of());
}
public Blob(
- String type, List<Integer> inputFields, long snapshotId, long
sequenceNumber,
- ByteBuffer blobData, @Nullable PuffinCompressionCodec
requestedCompression, Map<String, String> properties) {
+ String type, List<Integer> inputFields, ByteBuffer blobData,
+ @Nullable PuffinCompressionCodec requestedCompression, Map<String,
String> properties) {
Preconditions.checkNotNull(type, "type is null");
Preconditions.checkNotNull(inputFields, "inputFields is null");
Preconditions.checkNotNull(blobData, "blobData is null");
Preconditions.checkNotNull(properties, "properties is null");
this.type = type;
this.inputFields = ImmutableList.copyOf(inputFields);
- this.snapshotId = snapshotId;
- this.sequenceNumber = sequenceNumber;
Review Comment:
It's related. Since we're now attaching the stats snapshot to the given
snapshot, we don't need to track blob's source snapshot id. We actually don't
need to merge the stat files. Thus, we can simplify, by dropping some of the
complexity.
sure, i can drop the revert commit, if you want me to, but i am trying to
think about use-cases we're solving by keeping this in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
