flyrain commented on code in PR #5327:
URL: https://github.com/apache/iceberg/pull/5327#discussion_r929423566
##########
api/src/main/java/org/apache/iceberg/catalog/SessionCatalog.java:
##########
@@ -147,10 +147,11 @@ public Map<String, String> properties() {
* @param context session context
* @param ident a table identifier
* @param metadataFileLocation the location of a metadata file
+ * @param force default is false. If true, do register table even if table
exists otherwise it will throw error.
* @return a Table instance
* @throws AlreadyExistsException if the table already exists in the catalog.
*/
- Table registerTable(SessionContext context, TableIdentifier ident, String
metadataFileLocation);
+ Table registerTable(SessionContext context, TableIdentifier ident, String
metadataFileLocation, boolean force);
Review Comment:
It is a bit confusing for user by reusing the name `registerTable` for
updating the metadata location, even with the `force` option. Also `updating
metadata location` is a risky operation, we need to separate it from a safe
operation(register a table), so that user won't accidentally do that. Suggested
names would be `resetTable` or `resetMetadataLocation`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
