szlta commented on code in PR #131:
URL: https://github.com/apache/iceberg-docs/pull/131#discussion_r933407682
##########
docs/config.toml:
##########
@@ -34,9 +34,10 @@ home = [ "HTML", "RSS", "SearchIndex" ]
{ name = "Quickstart", url = "/spark-quickstart", weight = 100 },
{ name = "Docs", url = "/docs/latest", weight = 200 },
{ name = "Releases", pre = "relative", url = "../../releases", weight =
600 },
+ { name = "Roadmap", pre = "relative", url = "../../roadmap", weight = 997
},
{ name = "Blogs", pre = "relative", url = "../../blogs", weight = 998 },
{ name = "Talks", pre = "relative", url = "../../talks", weight = 999 },
- { name = "Roadmap", pre = "relative", url = "../../roadmap", weight = 997
},
+ { name = "Vendors", pre = "relative", url = "../../vendors", weight = 1000
},
Review Comment:
The home page body rather shows features of what Iceberg can do currently.
Actually it begins with "What is Iceberg" and is kind of describing it further
down. I don't really see how a vendor blurb could fit among these feature
descriptions/examples.
IMHO a 'Vendors' link is better placed wherever external materials are
already, and thus I think the place next to Blogs and Talks is more suitable.
We could reposition Vendors elsewhere, but then I'd suggest to bring Blogs and
Talks too with it. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
