rdblue commented on code in PR #5348:
URL: https://github.com/apache/iceberg/pull/5348#discussion_r933453435
##########
api/src/main/java/org/apache/iceberg/metrics/MetricsContext.java:
##########
@@ -106,6 +106,14 @@ default Timer timer(String name, TimeUnit unit) {
throw new UnsupportedOperationException("Timer is not supported.");
}
+ default <T extends Number> Gauge<T> gauge(String name, Class<T> type) {
+ throw new UnsupportedOperationException("Gauge is not supported.");
+ }
+
+ default Histogram histogram(String name, int reservoirSize) {
Review Comment:
Should we have these?
```
public <T extends Counter & Histogram> histCounter(String name, int
reservoirSize) {...}
public <T extends Timer & Histogram> histTimer(String name, int
reservoirSize) {...}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
