rdblue commented on code in PR #5377:
URL: https://github.com/apache/iceberg/pull/5377#discussion_r933462631


##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/SparkTestBaseWithCatalog.java:
##########
@@ -80,6 +80,7 @@ public SparkTestBaseWithCatalog(
     spark.conf().set("spark.sql.catalog." + catalogName, implementation);
     config.forEach(
         (key, value) -> spark.conf().set("spark.sql.catalog." + catalogName + 
"." + key, value));
+    spark.conf().set("spark.sql.defaultCatalog", catalogName);

Review Comment:
   Why set this for all tests? If you need it set in the new one, isn't it 
better to set it only in that test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to