szehon-ho commented on code in PR #5378:
URL: https://github.com/apache/iceberg/pull/5378#discussion_r933692766
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/CachedClientPool.java:
##########
@@ -56,9 +57,16 @@ public class CachedClientPool implements
ClientPool<IMetaStoreClient, TException
init();
}
+ @VisibleForTesting
+ static String cacheKey(Configuration conf) {
+ return String.format(
+ "%s:%s",
+ conf.get(HiveConf.ConfVars.METASTOREURIS.varname, ""),
conf.get(CATALOG_DEFAULT, ""));
Review Comment:
Yea I was mentioning this too, and internally debating whether its
overengineering. But I wonder , is the list of config something we should
expose say via HiveCatalog or just a static list? I also dont like that if we
change the timeout, it can take 5 minutes for a new client to spawn with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
