rdblue commented on code in PR #5338: URL: https://github.com/apache/iceberg/pull/5338#discussion_r933876300
########## .palantir/revapi.yml: ########## @@ -1,6 +1,17 @@ versionOverrides: org.apache.iceberg:iceberg-api:apache-iceberg-0.14.0: "0.14.0" acceptedBreaks: + list: + org.apache.iceberg:iceberg-api: + - code: "java.field.removed" + old: "field org.apache.iceberg.ManifestFile.ADDED_FILES_COUNT" + justification: "Removes inconsistency between code and spec" + - code: "java.field.removed" + old: "field org.apache.iceberg.ManifestFile.DELETED_FILES_COUNT" + justification: "Removes inconsistency between code and spec" + - code: "java.field.removed" + old: "field org.apache.iceberg.ManifestFile.EXISTING_FILES_COUNT" + justification: "Removes inconsistency between code and spec" Review Comment: Since we are going to be releasing 1.0 and can't deprecate these properly, can we leave the static field name intact and make it an alias for the correct one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
