nastra commented on PR #5312: URL: https://github.com/apache/iceberg/pull/5312#issuecomment-1200879863
@zinking we had to pick one format that produce the same format and can be enforced across cmd line / Eclipse / Intellij and we went with the *google-java-format*, which has a line length of 100 (and is not customizable unfortunately). We had to do this short-term disruption for the sake of long-term consistency and to overall improve the project. For some context about why Spotless + *google-java-format* was chosen, please refer to the [ML thread](https://lists.apache.org/thread/rkv5omc5hfpyx9w87frhdyggbgvpv6sw). In order to reduce the amount of conflicts, please follow the below steps: 1. Rebase your PR branch against the commit before the „Big Bang“ 2. Run `./gradlew spotlessApply` 3. Squash all commits 4. Rebase against the latest HEAD of the master branch 5. Force-push your branch Additionally, make sure to install the *google-java-format* plugin for your IDE as outlined in https://github.com/apache/iceberg-docs/pull/125 so that you can format code inside the IDE as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
