karuppayya commented on code in PR #5409:
URL: https://github.com/apache/iceberg/pull/5409#discussion_r935536830
##########
core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java:
##########
@@ -57,6 +63,25 @@ public static void visit(UpdateSchema api, Schema
existingSchema, Schema newSche
new PartnerIdByNameAccessors(existingSchema));
}
+ /**
+ * Adds changes needed to produce a union of two schemas to an {@link
UpdateSchema} operation.
+ *
+ * <p>Changes are accumulated to evolve the existingSchema into a union with
newSchema.
+ *
+ * @param api an UpdateSchema for adding changes
+ * @param existingSchema an existing schema
+ * @param caseSensitive when tfalse, the case of schema's fields are ignored
Review Comment:
the method is static and the field member is not accessible in the static
context.
##########
core/src/main/java/org/apache/iceberg/SchemaUpdate.java:
##########
@@ -61,6 +61,7 @@ class SchemaUpdate implements UpdateSchema {
private int lastColumnId;
private boolean allowIncompatibleChanges = false;
private Set<String> identifierFieldNames;
+ private boolean caseSensitive;
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
