szehon-ho commented on code in PR #5382:
URL: https://github.com/apache/iceberg/pull/5382#discussion_r935922258


##########
api/src/main/java/org/apache/iceberg/Scan.java:
##########
@@ -137,6 +144,13 @@
    */
   CloseableIterable<G> planTasks();
 
+  /**
+   * Returns whether this scan is case-sensitive with respect to column names.
+   *
+   * @return true if case-sensitive, false otherwise.
+   */
+  boolean isCaseSensitive();

Review Comment:
   Nit: Realize its a move, but the new getter locations seem inconsistent?   
maybe we could move the caseSensitive() getter up to the setter, or just put 
the other getter (filter) to the bottom of the file?  (This comment would apply 
to all the files) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to