rdblue commented on code in PR #5348:
URL: https://github.com/apache/iceberg/pull/5348#discussion_r937309573
##########
api/src/main/java/org/apache/iceberg/metrics/DefaultMetricsContext.java:
##########
@@ -22,6 +22,7 @@
/** A default {@link MetricsContext} implementation that uses native Java
counters/timers. */
public class DefaultMetricsContext implements MetricsContext {
+ private static final int DEFAULT_HISTOGRAM_RESERVOIR_SIZE = 1024;
Review Comment:
How about using 10k, rather than 1k? If we use reservoir sampling, then that
would give us about 100 data points for percentiles, which seems like a good
enough default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
