aokolnychyi commented on code in PR #5382: URL: https://github.com/apache/iceberg/pull/5382#discussion_r938418283
########## core/src/main/java/org/apache/iceberg/BaseIncrementalScan.java: ########## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import org.apache.iceberg.events.IncrementalScanEvent; +import org.apache.iceberg.events.Listeners; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.util.SnapshotUtil; + +abstract class BaseIncrementalScan<ThisT, T extends ScanTask, G extends ScanTaskGroup<T>> + extends BaseScan<ThisT, T, G> implements IncrementalScan<ThisT, T, G> { + + protected BaseIncrementalScan( + TableOperations ops, Table table, Schema schema, TableScanContext context) { + super(ops, table, schema, context); + } + + protected abstract CloseableIterable<T> doPlanFiles( + Long fromSnapshotIdExclusive, long toSnapshotIdInclusive); + + @Override + public ThisT fromSnapshotInclusive(long fromSnapshotId) { + Preconditions.checkArgument( + table().snapshot(fromSnapshotId) != null, + "Cannot find the starting snapshot: %s", + fromSnapshotId); + TableScanContext newContext = context().fromSnapshotIdInclusive(fromSnapshotId); + return newRefinedScan(tableOps(), table(), schema(), newContext); + } + + @Override + public ThisT fromSnapshotExclusive(long fromSnapshotId) { + // for exclusive behavior, table().snapshot(fromSnapshotId) check can't be applied + // as fromSnapshotId could be matched to a parent snapshot that is already expired + TableScanContext newContext = context().fromSnapshotIdExclusive(fromSnapshotId); + return newRefinedScan(tableOps(), table(), schema(), newContext); + } + + @Override + public ThisT toSnapshot(long toSnapshotId) { + Preconditions.checkArgument( + table().snapshot(toSnapshotId) != null, "Cannot find the end snapshot: %s", toSnapshotId); + TableScanContext newContext = context().toSnapshotId(toSnapshotId); + return newRefinedScan(tableOps(), table(), schema(), newContext); + } + + @Override + public CloseableIterable<T> planFiles() { + if (scanCurrentLineage() && table().currentSnapshot() == null) { + // If the table is empty (no current snapshot) and both from and to snapshots aren't set, + // simply return an empty iterable. In this case, the listener notification is also skipped. + return CloseableIterable.empty(); + } + + long toSnapshotIdInclusive = toSnapshotIdInclusive(); + Long fromSnapshotIdExclusive = fromSnapshotIdExclusive(toSnapshotIdInclusive); + + if (fromSnapshotIdExclusive != null) { + Listeners.notifyAll( + new IncrementalScanEvent( + table().name(), + fromSnapshotIdExclusive, + toSnapshotIdInclusive, + filter(), + schema(), + false)); + } else { + Listeners.notifyAll( + new IncrementalScanEvent( + table().name(), + SnapshotUtil.oldestAncestorOf(table(), toSnapshotIdInclusive).snapshotId(), + toSnapshotIdInclusive, + filter(), + schema(), + true)); + } Review Comment: I think we should eventually add a builder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
